summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2017-09-29 07:34:42 +0300
committerAlex Deucher <alexander.deucher@amd.com>2017-09-29 20:02:54 +0300
commit6be663b5bdb7cc299b2aafca56be39f6618090ab (patch)
treeb162c7b820323a6fdf62e92939f729313108d98c /drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c
parentdb6c3bdcfe2d810338f90a13d415d43dd98d342b (diff)
downloadlinux-6be663b5bdb7cc299b2aafca56be39f6618090ab.tar.xz
amdgpu/dc: fix construct return values on irq service.
This just removes more unused return/errors paths. Signed-off-by: Dave Airlie <airlied@redhat.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c')
-rw-r--r--drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c b/drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c
index d6e1fb665d90..8a2066c313fe 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dce80/irq_service_dce80.c
@@ -277,17 +277,14 @@ static const struct irq_service_funcs irq_service_funcs_dce80 = {
.to_dal_irq_source = to_dal_irq_source_dce110
};
-static bool construct(
+static void construct(
struct irq_service *irq_service,
struct irq_service_init_data *init_data)
{
- if (!dal_irq_service_construct(irq_service, init_data))
- return false;
+ dal_irq_service_construct(irq_service, init_data);
irq_service->info = irq_source_info_dce80;
irq_service->funcs = &irq_service_funcs_dce80;
-
- return true;
}
struct irq_service *dal_irq_service_dce80_create(
@@ -299,11 +296,8 @@ struct irq_service *dal_irq_service_dce80_create(
if (!irq_service)
return NULL;
- if (construct(irq_service, init_data))
- return irq_service;
-
- kfree(irq_service);
- return NULL;
+ construct(irq_service, init_data);
+ return irq_service;
}