diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2018-05-26 20:25:10 +0300 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2018-09-03 16:13:28 +0300 |
commit | 79ddb2f0c348e991edca106a0e5ab414a822ccfc (patch) | |
tree | 2f120c440d6b07294f324d20e5b6b48cb4a63ea4 /drivers/gpu/drm/omapdrm/dss/base.c | |
parent | 511afb44d72aa7b6b871fa71f829afaaa27e84f0 (diff) | |
download | linux-79ddb2f0c348e991edca106a0e5ab414a822ccfc.tar.xz |
drm/omap: dss: Move connection checks to omapdss_device_(dis)connect
When a DSS output is (dis)connected the omapdss_output_(un)set_device()
function performs a sanity check to ensure that the output isn't already
(dis)connected. The check is unnecessary as those situations should
never happen, but can nonetheless be useful to catch driver bugs. To
prepare for removal of the omapdss_output_(un)set_device() functions
move the connection check to the omapdss_device_connect() function. The
omapdss_device_disconnect() already contains a corresponding check.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/gpu/drm/omapdrm/dss/base.c')
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/base.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c index c3e451440d4b..02c6ed97d632 100644 --- a/drivers/gpu/drm/omapdrm/dss/base.c +++ b/drivers/gpu/drm/omapdrm/dss/base.c @@ -208,6 +208,7 @@ int omapdss_device_connect(struct dss_device *dss, } if (src) { + WARN_ON(src->dst); dst->src = src; src->dst = dst; } |