summaryrefslogtreecommitdiff
path: root/drivers/iio/accel
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2020-05-17 20:29:57 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2020-06-14 14:32:22 +0300
commitf88ecccac4be348bbcc6d056bdbc622a8955c04d (patch)
tree7967e7b5b25117067517111153bb7bc4c09c692c /drivers/iio/accel
parent3f9c6d38797e9903937b007a341dad0c251765d6 (diff)
downloadlinux-f88ecccac4be348bbcc6d056bdbc622a8955c04d.tar.xz
iio:health:afe4404 Fix timestamp alignment and prevent data leak.
One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses a 40 byte array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data with alignment explicitly requested. This data is allocated with kzalloc so no data can leak appart from previous readings. Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Andrew F. Davis <afd@ti.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/accel')
0 files changed, 0 insertions, 0 deletions