summaryrefslogtreecommitdiff
path: root/drivers/iio/dac
diff options
context:
space:
mode:
authorZizhuang Deng <sunsetdzz@gmail.com>2022-03-10 15:54:50 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2022-04-04 11:19:01 +0300
commitb55b38f7cc12da3b9ef36e7a3b7f8f96737df4d5 (patch)
tree240ba14452ce0f48633ad4bbcbe0bb039169aa8a /drivers/iio/dac
parenta2a43fd9d84aec15f8c3dc434d50cd59d8a116b2 (diff)
downloadlinux-b55b38f7cc12da3b9ef36e7a3b7f8f96737df4d5.tar.xz
iio: dac: ad5592r: Fix the missing return value.
The third call to `fwnode_property_read_u32` did not record the return value, resulting in `channel_offstate` possibly being assigned the wrong value. Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs") Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com> Link: https://lore.kernel.org/r/20220310125450.4164164-1-sunsetdzz@gmail.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/dac')
-rw-r--r--drivers/iio/dac/ad5592r-base.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
index a424b7220b61..4434c1b2a322 100644
--- a/drivers/iio/dac/ad5592r-base.c
+++ b/drivers/iio/dac/ad5592r-base.c
@@ -522,7 +522,7 @@ static int ad5592r_alloc_channels(struct iio_dev *iio_dev)
if (!ret)
st->channel_modes[reg] = tmp;
- fwnode_property_read_u32(child, "adi,off-state", &tmp);
+ ret = fwnode_property_read_u32(child, "adi,off-state", &tmp);
if (!ret)
st->channel_offstate[reg] = tmp;
}