summaryrefslogtreecommitdiff
path: root/drivers/input/touchscreen/stmfts.c
diff options
context:
space:
mode:
authorZheng Yongjun <zhengyongjun3@huawei.com>2022-03-21 07:56:38 +0300
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2022-03-21 07:59:43 +0300
commit26623eea0da3476446909af96c980768df07bbd9 (patch)
tree35aaddc5470bc00c0266b7e82d4676c781450566 /drivers/input/touchscreen/stmfts.c
parent409353cbe9fe48f6bc196114c442b1cff05a39bc (diff)
downloadlinux-26623eea0da3476446909af96c980768df07bbd9.tar.xz
Input: stmfts - fix reference leak in stmfts_input_open
pm_runtime_get_sync() will increment pm usage counter even it failed. Forgetting to call pm_runtime_put_noidle will result in reference leak in stmfts_input_open, so we should fix it. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/touchscreen/stmfts.c')
-rw-r--r--drivers/input/touchscreen/stmfts.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index bc11203c9cf7..72e0b767e1ba 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -339,11 +339,11 @@ static int stmfts_input_open(struct input_dev *dev)
err = pm_runtime_get_sync(&sdata->client->dev);
if (err < 0)
- return err;
+ goto out;
err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON);
if (err)
- return err;
+ goto out;
mutex_lock(&sdata->mutex);
sdata->running = true;
@@ -366,7 +366,9 @@ static int stmfts_input_open(struct input_dev *dev)
"failed to enable touchkey\n");
}
- return 0;
+out:
+ pm_runtime_put_noidle(&sdata->client->dev);
+ return err;
}
static void stmfts_input_close(struct input_dev *dev)