summaryrefslogtreecommitdiff
path: root/drivers/leds/leds-as3645a.c
diff options
context:
space:
mode:
authorSakari Ailus <sakari.ailus@linux.intel.com>2019-12-04 10:56:42 +0300
committerPavel Machek <pavel@ucw.cz>2020-01-22 23:07:10 +0300
commit22cb0a76e0059701bce395bd8832ea94342cbf4a (patch)
tree6a2b3855b663763c7fc5ffdaa389276b213fbeaa /drivers/leds/leds-as3645a.c
parent90a8e82d3ca8c1f85ac63f4a94c9b034f05af4ee (diff)
downloadlinux-22cb0a76e0059701bce395bd8832ea94342cbf4a.tar.xz
leds-as3645a: Drop fwnode reference on ignored node
If a node is ignored, do not get a reference to it. Fix the bug by moving fwnode_handle_get() where a reference to an fwnode is saved for clarity. Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds/leds-as3645a.c')
-rw-r--r--drivers/leds/leds-as3645a.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index b7e0ae1af8fa..e8922fa03379 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -493,16 +493,17 @@ static int as3645a_parse_node(struct as3645a *flash,
switch (id) {
case AS_LED_FLASH:
flash->flash_node = child;
+ fwnode_handle_get(child);
break;
case AS_LED_INDICATOR:
flash->indicator_node = child;
+ fwnode_handle_get(child);
break;
default:
dev_warn(&flash->client->dev,
"unknown LED %u encountered, ignoring\n", id);
break;
}
- fwnode_handle_get(child);
}
if (!flash->flash_node) {