diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2024-04-05 23:53:08 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2024-04-12 11:47:14 +0300 |
| commit | 1fe4f1bf60fdd2110480e8be8b084fcb2b1df656 (patch) | |
| tree | 8b9c140ce85d5d6ef088520488e4d50e49c04b0b /drivers/leds | |
| parent | 77b9f2d6fd9bf34ec810de6bdad42d7d0a47d31b (diff) | |
| download | linux-1fe4f1bf60fdd2110480e8be8b084fcb2b1df656.tar.xz | |
leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate
led_trigger_set() is the only caller of the deactivate() callback,
and it calls led_set_brightness(LED_OFF) anyway after deactivate().
So we can remove the call here.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/8dc929e7-8e14-4c85-aa28-9c5fe2620f52@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/trigger/ledtrig-netdev.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index ea00f6c70882..22bba8e97642 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -724,8 +724,6 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev) cancel_delayed_work_sync(&trigger_data->work); - led_set_brightness(led_cdev, LED_OFF); - dev_put(trigger_data->net_dev); kfree(trigger_data); |