diff options
| author | Henning Schild <henning.schild@siemens.com> | 2022-10-07 18:33:23 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-01-30 11:03:43 +0300 |
| commit | c64964ebee2a415384385205950ee7a05f78451e (patch) | |
| tree | 46af132a8775cbabac3b15cf047f501d22221f3d /drivers/leds | |
| parent | 8f47707acd0b65a9e797bc7288a9183131d5ce74 (diff) | |
| download | linux-c64964ebee2a415384385205950ee7a05f78451e.tar.xz | |
leds: simatic-ipc-leds-gpio: Make sure we have the GPIO providing driver
If we register a "leds-gpio" platform device for GPIO pins that do not
exist we get a -EPROBE_DEFER and the probe will be tried again later.
If there is no driver to provide that pin we will poll forever and also
create a lot of log messages.
So check if that GPIO driver is configured, if so it will come up
eventually. If not, we exit our probe function early and do not even
bother registering the "leds-gpio". This method was chosen over "Kconfig
depends" since this way we can add support for more devices and GPIO
backends more easily without "depends":ing on all GPIO backends.
Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Signed-off-by: Henning Schild <henning.schild@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221007153323.1326-1-henning.schild@siemens.com
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c index 07f0d79d604d..e8d329b5a68c 100644 --- a/drivers/leds/simple/simatic-ipc-leds-gpio.c +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c @@ -77,6 +77,8 @@ static int simatic_ipc_leds_gpio_probe(struct platform_device *pdev) switch (plat->devmode) { case SIMATIC_IPC_DEVICE_127E: + if (!IS_ENABLED(CONFIG_PINCTRL_BROXTON)) + return -ENODEV; simatic_ipc_led_gpio_table = &simatic_ipc_led_gpio_table_127e; break; case SIMATIC_IPC_DEVICE_227G: |