diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2022-07-12 13:47:15 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-07-15 17:41:15 +0300 |
| commit | b4d1d5c65de9ac85b0d6cb11c80caad0178b303e (patch) | |
| tree | e5ecdbe7f39c3f4abce45e991640ea3f60f886c3 /drivers/media/platform/qcom/venus/helpers.c | |
| parent | 109670df7dfed3fa0cb33e0868a889f4f512b698 (diff) | |
| download | linux-b4d1d5c65de9ac85b0d6cb11c80caad0178b303e.tar.xz | |
media: venus: venus_helper_get_bufreq(): req is never NULL
Fix a smatch error:
drivers/media/platform/qcom/venus/helpers.c: drivers/media/platform/qcom/venus/helpers.c:678 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 674)
After checking how venus_helper_get_bufreq() is called it is clear that
req is never NULL, so just drop the checks.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/platform/qcom/venus/helpers.c')
| -rw-r--r-- | drivers/media/platform/qcom/venus/helpers.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 5c1104379c49..60de4200375d 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -671,8 +671,7 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type, unsigned int i; int ret; - if (req) - memset(req, 0, sizeof(*req)); + memset(req, 0, sizeof(*req)); if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2) req->count_min = inst->fw_min_cnt; @@ -694,8 +693,7 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type, if (hprop.bufreq[i].type != type) continue; - if (req) - memcpy(req, &hprop.bufreq[i], sizeof(*req)); + memcpy(req, &hprop.bufreq[i], sizeof(*req)); ret = 0; break; } |