summaryrefslogtreecommitdiff
path: root/drivers/media/rc/ite-cir.h
diff options
context:
space:
mode:
authorJarod Wilson <jarod@redhat.com>2011-06-08 01:45:17 +0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-07-01 23:31:38 +0400
commit35d136c8dab034ee14aa00d6082229b4b74607da (patch)
tree50f289be3e05bd0121bf8d2520530c7f0f58a1fd /drivers/media/rc/ite-cir.h
parent258c05637d6b6df2478a2808a3d2350c3c6782d6 (diff)
downloadlinux-35d136c8dab034ee14aa00d6082229b4b74607da.tar.xz
[media] ite-cir: 8709 needs to use pnp resource 2
Thanks to the intrepid testing and debugging of Matthijs van Drunen, it was uncovered that at least some variants of the ITE8709 need to use pnp resource 2, rather than 0, for things to function properly. Resource 0 has a length of only 1, and if you try to bypass the pnp_port_len check and use it anyway (with either a length of 1 or 2), the system in question's trackpad ceased to function. The circa lirc 0.8.7 lirc_ite8709 driver used resource 2, but the value was (amusingly) changed to 0 by way of a patch from ITE themselves, so I don't know if there may be variants where 0 actually *is* correct, but at least in this case and in the original lirc_ite8709 driver author's case, it sure looks like 2 is the right value. This fix should probably be applied to all stable kernels with the ite-cir driver, lest we nuke more people's trackpads. Tested-by: Matthijs van Drunen CC: Juan Jesús García de Soria <skandalfo@gmail.com> CC: stable@kernel.org Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/rc/ite-cir.h')
-rw-r--r--drivers/media/rc/ite-cir.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/media/rc/ite-cir.h b/drivers/media/rc/ite-cir.h
index 16a19f5fd718..aa899a0b9750 100644
--- a/drivers/media/rc/ite-cir.h
+++ b/drivers/media/rc/ite-cir.h
@@ -57,6 +57,9 @@ struct ite_dev_params {
/* size of the I/O region */
int io_region_size;
+ /* IR pnp I/O resource number */
+ int io_rsrc_no;
+
/* true if the hardware supports transmission */
bool hw_tx_capable;