diff options
author | Ming Lei <ming.lei@redhat.com> | 2021-06-28 05:33:12 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-06-29 16:41:08 +0300 |
commit | 2705dfb2094777e405e065105e307074af8965c1 (patch) | |
tree | 1fdc528a77f5be9455dcedf07b303dbceac04bd1 /drivers/memstick | |
parent | c06bc5a3fb42304d815a2dc41e324b5a97c9f7da (diff) | |
download | linux-2705dfb2094777e405e065105e307074af8965c1.tar.xz |
block: fix discard request merge
ll_new_hw_segment() is reached only in case of single range discard
merge, and we don't have max discard segment size limit actually, so
it is wrong to run the following check:
if (req->nr_phys_segments + nr_phys_segs > blk_rq_get_max_segments(req))
it may be always false since req->nr_phys_segments is initialized as
one, and bio's segment count is still 1, blk_rq_get_max_segments(reg)
is 1 too.
Fix the issue by not doing the check and bypassing the calculation of
discard request's nr_phys_segments.
Based on analysis from Wang Shanker.
Cc: Christoph Hellwig <hch@lst.de>
Reported-by: Wang Shanker <shankerwangmiao@gmail.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20210628023312.1903255-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/memstick')
0 files changed, 0 insertions, 0 deletions