summaryrefslogtreecommitdiff
path: root/drivers/mfd/ipaq-micro.c
diff options
context:
space:
mode:
authorLv Ruyi <lv.ruyi@zte.com.cn>2022-04-12 11:53:05 +0300
committerLee Jones <lee.jones@linaro.org>2022-04-26 17:12:22 +0300
commit3b49ae380ce1a3054e0c505dd9a356b82a5b48e8 (patch)
tree918d0440032aa7e19fd4db088bc7739fc44a4918 /drivers/mfd/ipaq-micro.c
parent7f5aaa4a0ae6948eace6cf30f40a3ec27ece8441 (diff)
downloadlinux-3b49ae380ce1a3054e0c505dd9a356b82a5b48e8.tar.xz
mfd: ipaq-micro: Fix error check return value of platform_get_irq()
platform_get_irq() return negative value on failure, so null check of irq is incorrect. Fix it by comparing whether it is less than zero. Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx") Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn
Diffstat (limited to 'drivers/mfd/ipaq-micro.c')
-rw-r--r--drivers/mfd/ipaq-micro.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index e92eeeb67a98..4cd5ecc72211 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -403,7 +403,7 @@ static int __init micro_probe(struct platform_device *pdev)
micro_reset_comm(micro);
irq = platform_get_irq(pdev, 0);
- if (!irq)
+ if (irq < 0)
return -EINVAL;
ret = devm_request_irq(&pdev->dev, irq, micro_serial_isr,
IRQF_SHARED, "ipaq-micro",