summaryrefslogtreecommitdiff
path: root/drivers/misc/c2port
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2020-11-02 17:20:00 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-11-03 12:12:10 +0300
commite8f50d4bfc8deff61adc74146f130860c4fe356f (patch)
treee9080c1c4cb86d70c8e00bbfab7a6c92758ae673 /drivers/misc/c2port
parentc78c95f919539cad0308e7de0d5d0d656e4a8e98 (diff)
downloadlinux-e8f50d4bfc8deff61adc74146f130860c4fe356f.tar.xz
misc: c2port: core: Make copying name from userspace more secure
Currently the 'c2dev' device data is not initialised when it's allocated. There maybe an issue when using strncpy() to populate the 'name' attribute since a NUL terminator may not be provided in all use-cases. To prevent such a failing, let's ensure the 'c2dev' device data area is fully zeroed out on allocation. Cc: Rodolfo Giometti <giometti@enneenne.com> Cc: "Eurotech S.p.A" <info@eurotech.it> Cc: David Laight <David.Laight@aculab.com> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20201102142001.560490-1-lee.jones@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/c2port')
-rw-r--r--drivers/misc/c2port/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
index 80d87e8a0bea..fb9a1b49ff6d 100644
--- a/drivers/misc/c2port/core.c
+++ b/drivers/misc/c2port/core.c
@@ -899,7 +899,7 @@ struct c2port_device *c2port_device_register(char *name,
unlikely(!ops->c2d_get) || unlikely(!ops->c2d_set))
return ERR_PTR(-EINVAL);
- c2dev = kmalloc(sizeof(struct c2port_device), GFP_KERNEL);
+ c2dev = kzalloc(sizeof(struct c2port_device), GFP_KERNEL);
if (unlikely(!c2dev))
return ERR_PTR(-ENOMEM);