diff options
| author | Lu Hongfei <luhongfei@vivo.com> | 2023-07-10 06:18:59 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-07-11 11:53:14 +0300 |
| commit | 04499f28b40bfc24f20b0e2331008bb90a54a6cf (patch) | |
| tree | e57d88b483be543da1ded8ab441c2b1b68f76a8e /drivers/net/dsa | |
| parent | c0dbbdf56f13c960aa6bedf61302f57411ae4865 (diff) | |
| download | linux-04499f28b40bfc24f20b0e2331008bb90a54a6cf.tar.xz | |
net: dsa: Removed unneeded of_node_put in felix_parse_ports_node
Remove unnecessary of_node_put from the continue path to prevent
child node from being released twice, which could avoid resource
leak or other unexpected issues.
Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Fixes: de879a016a94 ("net: dsa: felix: add functionality when not all ports are supported")
Link: https://lore.kernel.org/r/20230710031859.36784-1-luhongfei@vivo.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/ocelot/felix.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index dee43caee19e..8da46d284e35 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1286,7 +1286,6 @@ static int felix_parse_ports_node(struct felix *felix, if (err < 0) { dev_info(dev, "Unsupported PHY mode %s on port %d\n", phy_modes(phy_mode), port); - of_node_put(child); /* Leave port_phy_modes[port] = 0, which is also * PHY_INTERFACE_MODE_NA. This will perform a |