summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/faraday
diff options
context:
space:
mode:
authorKevin Mitchell <kevmitch@arista.com>2022-05-17 21:01:05 +0300
committerDavid S. Miller <davem@davemloft.net>2022-05-18 16:00:51 +0300
commit942d2ad5d2e0df758a645ddfadffde2795322728 (patch)
tree8756518dee9f8bf1479973a589738d84d2056aac /drivers/net/ethernet/faraday
parentb8cedb7093b2d1394cae9b86494cba4b62d3a30a (diff)
downloadlinux-942d2ad5d2e0df758a645ddfadffde2795322728.tar.xz
igb: skip phy status check where unavailable
igb_read_phy_reg() will silently return, leaving phy_data untouched, if hw->ops.read_reg isn't set. Depending on the uninitialized value of phy_data, this led to the phy status check either succeeding immediately or looping continuously for 2 seconds before emitting a noisy err-level timeout. This message went out to the console even though there was no actual problem. Instead, first check if there is read_reg function pointer. If not, proceed without trying to check the phy status register. Fixes: b72f3f72005d ("igb: When GbE link up, wait for Remote receiver status condition") Signed-off-by: Kevin Mitchell <kevmitch@arista.com> Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/faraday')
0 files changed, 0 insertions, 0 deletions