diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-18 10:07:07 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-08-20 17:13:27 +0300 |
| commit | 294f48e9b234415cbd8cc4e233d5fbd41e961148 (patch) | |
| tree | a6ddcfd51cb1d1f10394782a1071c7d39ff6dd09 /drivers/net/ethernet/microchip | |
| parent | acf50d1adbf440a01fc9cca16e80dde3da3eccab (diff) | |
| download | linux-294f48e9b234415cbd8cc4e233d5fbd41e961148.tar.xz | |
net: lan743x: Return PTR_ERR() for fixed_phy_register()
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -EIO. The Best practice is to return these
error codes with PTR_ERR().
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip')
| -rw-r--r-- | drivers/net/ethernet/microchip/lan743x_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index a36f6369f132..c81cdeb4d4e7 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1515,7 +1515,7 @@ static int lan743x_phy_open(struct lan743x_adapter *adapter) &fphy_status, NULL); if (IS_ERR(phydev)) { netdev_err(netdev, "No PHY/fixed_PHY found\n"); - return -EIO; + return PTR_ERR(phydev); } } else { goto return_error; |