diff options
| author | Asbjørn Sloth Tønnesen <ast@fiberby.net> | 2024-04-11 13:52:55 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-04-15 12:33:14 +0300 |
| commit | e36245dacd2cca4be716e4096b7dc6df9c8a7a6b (patch) | |
| tree | 5f85a015822b233e12b46db73c60ad5d73a515f9 /drivers/net/ethernet/netronome | |
| parent | d11e63119432bdb55065d094cb6fd37e9147c70d (diff) | |
| download | linux-e36245dacd2cca4be716e4096b7dc6df9c8a7a6b.tar.xz | |
nfp: flower: fix check for unsupported control flags
Use flow_rule_is_supp_control_flags()
Check the mask, not the key, for unsupported control flags.
Only compile-tested, no access to HW
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/netronome')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/flower/offload.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c index 0aceef9fe582..8e0a890381b6 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c @@ -527,10 +527,10 @@ nfp_flower_calculate_key_layers(struct nfp_app *app, struct flow_match_control ctl; flow_rule_match_control(rule, &ctl); - if (ctl.key->flags & ~NFP_FLOWER_SUPPORTED_CTLFLAGS) { - NL_SET_ERR_MSG_MOD(extack, "unsupported offload: match on unknown control flag"); + + if (!flow_rule_is_supp_control_flags(NFP_FLOWER_SUPPORTED_CTLFLAGS, + ctl.mask->flags, extack)) return -EOPNOTSUPP; - } } ret_key_ls->key_layer = key_layer; |