diff options
| author | Jiawen Wu <jiawenwu@trustnetic.com> | 2023-11-17 13:11:08 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-19 22:43:54 +0300 |
| commit | 8ba2c459668cfe2aaacc5ebcd35b4b9ef8643013 (patch) | |
| tree | c272114d8a11fe9ac9495c91ebd745e47e3ad16a /drivers/net/ethernet/wangxun/ngbe | |
| parent | 76df934c6d5f5c93ba7a0112b1818620ddc10b19 (diff) | |
| download | linux-8ba2c459668cfe2aaacc5ebcd35b4b9ef8643013.tar.xz | |
net: wangxun: fix kernel panic due to null pointer
When the device uses a custom subsystem vendor ID, the function
wx_sw_init() returns before the memory of 'wx->mac_table' is allocated.
The null pointer will causes the kernel panic.
Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/wangxun/ngbe')
| -rw-r--r-- | drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c index 3d43f808c86b..8db804543e66 100644 --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c @@ -121,10 +121,8 @@ static int ngbe_sw_init(struct wx *wx) /* PCI config space info */ err = wx_sw_init(wx); - if (err < 0) { - wx_err(wx, "read of internal subsystem device id failed\n"); + if (err < 0) return err; - } /* mac type, phy type , oem type */ ngbe_init_type_code(wx); |