diff options
| author | Oleksij Rempel <o.rempel@pengutronix.de> | 2021-06-07 11:27:21 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-07 23:23:02 +0300 |
| commit | 7e88b11a862afe59ee0c365123ea5fb96a26cb3b (patch) | |
| tree | ecf6cdec29146efc42de175162ec008b19305a9b /drivers/net/usb/ax88172a.c | |
| parent | 218d154f540a58b82394e128e425560181c1662e (diff) | |
| download | linux-7e88b11a862afe59ee0c365123ea5fb96a26cb3b.tar.xz | |
net: usb: asix: refactor asix_read_phy_addr() and handle errors on return
Refactor asix_read_phy_addr() to return usable error value directly and
make sure all callers handle this error.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/ax88172a.c')
| -rw-r--r-- | drivers/net/usb/ax88172a.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c index b404c9462dce..c8ca5187eece 100644 --- a/drivers/net/usb/ax88172a.c +++ b/drivers/net/usb/ax88172a.c @@ -220,6 +220,11 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf) } priv->phy_addr = asix_read_phy_addr(dev, priv->use_embdphy); + if (priv->phy_addr < 0) { + ret = priv->phy_addr; + goto free; + } + ax88172a_reset_phy(dev, priv->use_embdphy); /* Asix framing packs multiple eth frames into a 2K usb bulk transfer */ |