summaryrefslogtreecommitdiff
path: root/drivers/net/wireless/ath/ath10k/Kconfig
diff options
context:
space:
mode:
authorKalle Valo <quic_kvalo@quicinc.com>2022-12-02 13:30:27 +0300
committerKalle Valo <kvalo@kernel.org>2022-12-02 21:24:06 +0300
commitd03407183d97554dfffea70f385b5bdd520f846c (patch)
treeb923720e6f548eb8df95f1af1635830ceee0ed15 /drivers/net/wireless/ath/ath10k/Kconfig
parente9ab0b2e680b069437f54bf4076310f636af05e6 (diff)
downloadlinux-d03407183d97554dfffea70f385b5bdd520f846c.tar.xz
wifi: ath10k: fix QCOM_SMEM dependency
Nathan noticed that when HWSPINLOCK is disabled there's a Kconfig warning: WARNING: unmet direct dependencies detected for QCOM_SMEM Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n] Selected by [m]: - ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) The problem here is that QCOM_SMEM depends on HWSPINLOCK so we cannot select QCOM_SMEM and instead we neeed to use 'depends on'. Reported-by: Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/all/Y4YsyaIW+CPdHWv3@dev-arch.thelio-3990X/ Fixes: 4d79f6f34bbb ("wifi: ath10k: Store WLAN firmware version in SMEM image table") Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20221202103027.25974-1-kvalo@kernel.org
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/Kconfig')
-rw-r--r--drivers/net/wireless/ath/ath10k/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
index e0a51dad8e42..e6ea884cafc1 100644
--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -44,7 +44,7 @@ config ATH10K_SNOC
tristate "Qualcomm ath10k SNOC support"
depends on ATH10K
depends on ARCH_QCOM || COMPILE_TEST
- select QCOM_SMEM
+ depends on QCOM_SMEM
select QCOM_SCM
select QCOM_QMI_HELPERS
help