diff options
| author | Íñigo Huguet <ihuguet@redhat.com> | 2021-05-11 10:02:58 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2021-06-15 13:40:15 +0300 |
| commit | c0277e25d28fc534c09e140c19d5b85f9e7f86fd (patch) | |
| tree | 8014b4640e2640b42bad701d23d0d15c1cf7df5a /drivers/net/wireless/broadcom/brcm80211/brcmsmac | |
| parent | 885f256f61f958d494ffdf5084a292808f08daee (diff) | |
| download | linux-c0277e25d28fc534c09e140c19d5b85f9e7f86fd.tar.xz | |
brcmsmac: improve readability on addresses copy
A static analyzer identified as a potential bug the copy of
12 bytes from a 6 bytes array to a 6 bytes array. Both
arrays are 6 bytes addresses.
Although not being a real bug, it is not immediately clear
why is done this way: next 6 bytes address, contiguous to
the first one, must also be copied to next contiguous 6 bytes
address of the destination.
Copying each one separately will make both static analyzers
and reviewers happier.
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210511070257.7843-1-ihuguet@redhat.com
Diffstat (limited to 'drivers/net/wireless/broadcom/brcm80211/brcmsmac')
| -rw-r--r-- | drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c index 763e0ec583d7..26de1bd7fee9 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c @@ -6607,7 +6607,8 @@ brcms_c_d11hdrs_mac80211(struct brcms_c_info *wlc, struct ieee80211_hw *hw, rts->frame_control = cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_RTS); - memcpy(&rts->ra, &h->addr1, 2 * ETH_ALEN); + memcpy(&rts->ra, &h->addr1, ETH_ALEN); + memcpy(&rts->ta, &h->addr2, ETH_ALEN); } /* mainrate |