diff options
| author | Deren Wu <deren.wu@mediatek.com> | 2023-01-15 07:44:57 +0300 |
|---|---|---|
| committer | Felix Fietkau <nbd@nbd.name> | 2023-02-03 16:47:17 +0300 |
| commit | 5f54237ad798f41cb6a503271aa9ca47188cfb9b (patch) | |
| tree | 16cbc61ed524922381a4fdfb32f320112c99803a /drivers/net/wireless/mediatek/mt76/sdio.c | |
| parent | 09f4417a451be137a3e848b1888a1e32f8325046 (diff) | |
| download | linux-5f54237ad798f41cb6a503271aa9ca47188cfb9b.tar.xz | |
wifi: mt76: add memory barrier to SDIO queue kick
Ensure the entry has been fully updated before SDIO bus worker access
it. This patch would fix potential memory risk in both mt7663s and
mt7921s.
Fixes: 764dee47e2c1 ("mt76: sdio: move common code in mt76_sdio module")
Signed-off-by: Deren Wu <deren.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Diffstat (limited to 'drivers/net/wireless/mediatek/mt76/sdio.c')
| -rw-r--r-- | drivers/net/wireless/mediatek/mt76/sdio.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/sdio.c b/drivers/net/wireless/mediatek/mt76/sdio.c index 228bc7d45011..419723118ded 100644 --- a/drivers/net/wireless/mediatek/mt76/sdio.c +++ b/drivers/net/wireless/mediatek/mt76/sdio.c @@ -562,6 +562,10 @@ mt76s_tx_queue_skb_raw(struct mt76_dev *dev, struct mt76_queue *q, q->entry[q->head].buf_sz = len; q->entry[q->head].skb = skb; + + /* ensure the entry fully updated before bus access */ + smp_wmb(); + q->head = (q->head + 1) % q->ndesc; q->queued++; |