diff options
author | Rafał Miłecki <rafal@milecki.pl> | 2023-02-27 12:11:56 +0300 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2023-02-28 13:10:05 +0300 |
commit | f99e6d7c4ed3be2531bd576425a5bd07fb133bd7 (patch) | |
tree | cf1438946bc8827ca09bb539c2c1dd6006a288a2 /drivers/nfc | |
parent | 5ca26d6039a6b42341f7f5cc8d10d30ca1561a7b (diff) | |
download | linux-f99e6d7c4ed3be2531bd576425a5bd07fb133bd7.tar.xz |
bgmac: fix *initial* chip reset to support BCM5358
While bringing hardware up we should perform a full reset including the
switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
specification says and what reference driver does.
This seems to be critical for the BCM5358. Without this hardware doesn't
get initialized properly and doesn't seem to transmit or receive any
packets.
Originally bgmac was calling bgmac_chip_reset() before setting
"has_robosw" property which resulted in expected behaviour. That has
changed as a side effect of adding platform device support which
regressed BCM5358 support.
Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support")
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230227091156.19509-1-zajec5@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/nfc')
0 files changed, 0 insertions, 0 deletions