summaryrefslogtreecommitdiff
path: root/drivers/pinctrl
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2022-11-25 13:34:35 +0300
committerLinus Walleij <linus.walleij@linaro.org>2022-11-25 13:41:01 +0300
commit7ebfe10ec36b80637fe746dc2371ff1d9ce71efa (patch)
tree5235c633cd556a1e3af1bf47f921caaf0b36ca51 /drivers/pinctrl
parent5ead93289815a075d43c415e35c8beafafb801c9 (diff)
downloadlinux-7ebfe10ec36b80637fe746dc2371ff1d9ce71efa.tar.xz
pinctrl: loongson2: Fix some const correctness
The kernel robot using sparse is complaining like this: drivers/pinctrl/pinctrl-loongson2.c:212:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got void *[noderef] __iomem reg @@ (...) I think the problem is simply that the register base is defined as void * __iomem instead of void __iomem * and this is because of the way const correctness works with pointer infix order. Fix it up. I think. Reported-by: kernel test robot <lkp@intel.com> Cc: zhanghongchen <zhanghongchen@loongson.cn> Cc: Yinbo Zhu <zhuyinbo@loongson.cn> Fixes: f73f88acbc18 ("pinctrl: pinctrl-loongson2: add pinctrl driver support") Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r--drivers/pinctrl/pinctrl-loongson2.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-loongson2.c b/drivers/pinctrl/pinctrl-loongson2.c
index 1e9ec87e6930..a72ffeca26fb 100644
--- a/drivers/pinctrl/pinctrl-loongson2.c
+++ b/drivers/pinctrl/pinctrl-loongson2.c
@@ -45,7 +45,7 @@ struct loongson2_pinctrl {
struct pinctrl_desc desc;
struct device_node *of_node;
spinlock_t lock;
- void * __iomem reg_base;
+ void __iomem *reg_base;
};
struct loongson2_pmx_group {
@@ -202,7 +202,7 @@ static int loongson2_pmx_set_mux(struct pinctrl_dev *pcdev, unsigned int func_nu
unsigned int group_num)
{
struct loongson2_pinctrl *pctrl = pinctrl_dev_get_drvdata(pcdev);
- void * __iomem reg = pctrl->reg_base +
+ void __iomem *reg = pctrl->reg_base +
loongson2_pmx_groups[group_num].reg;
unsigned int mux_bit = loongson2_pmx_groups[group_num].bit;
unsigned int val;