diff options
| author | Arvid Norlander <lkml@vorpal.se> | 2022-08-21 23:08:21 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-08-26 13:57:29 +0300 |
| commit | 4058ea22d7ce26d3d71698768e636274d08e9ccd (patch) | |
| tree | 6c8faf4d644ae15b1727b5ce0ca47e68b129883a /drivers/platform/x86/toshiba_acpi.c | |
| parent | 23657a437ea2fbccc715fce2dac74e3c923540cf (diff) | |
| download | linux-4058ea22d7ce26d3d71698768e636274d08e9ccd.tar.xz | |
platform/x86: toshiba_acpi: Fix ECO LED control on Toshiba Z830
The toshiba_acpi driver checks for TOS_INPUT_DATA_ERROR and tries a
different format. On the Z830 the error returned is TOS_NOT_SUPPORTED
though the different format still works. Allow either error.
Signed-off-by: Arvid Norlander <lkml@vorpal.se>
Link: https://lore.kernel.org/r/20220821200821.1837460-2-lkml@vorpal.se
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/toshiba_acpi.c')
| -rw-r--r-- | drivers/platform/x86/toshiba_acpi.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 0fc9e8b8827b..6cc617b2940e 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -675,12 +675,15 @@ static void toshiba_eco_mode_available(struct toshiba_acpi_dev *dev) return; } - if (out[0] == TOS_INPUT_DATA_ERROR) { + if (out[0] == TOS_INPUT_DATA_ERROR || out[0] == TOS_NOT_SUPPORTED) { /* * If we receive 0x8300 (Input Data Error), it means that the * LED device is present, but that we just screwed the input * parameters. * + * On some laptops 0x8000 (Not supported) is also returned in + * this case, so we need to allow for that as well. + * * Let's query the status of the LED to see if we really have a * success response, indicating the actual presense of the LED, * bail out otherwise. |