summaryrefslogtreecommitdiff
path: root/drivers/soc
diff options
context:
space:
mode:
authorAnson Huang <Anson.Huang@nxp.com>2019-05-24 08:51:00 +0300
committerShawn Guo <shawnguo@kernel.org>2019-06-05 09:08:10 +0300
commitd8dfab0f4d0669ae299511e3ab3e79f312476f75 (patch)
treef33c9f29e168cb2318a1f5d769105211d7bc2cd8 /drivers/soc
parent15f5276a2fb1ad70d7a8e6321dd751c3d081e422 (diff)
downloadlinux-d8dfab0f4d0669ae299511e3ab3e79f312476f75.tar.xz
soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
of_node_put() is called after of_match_node() successfully called, then in the following error handling, of_node_put() is called again which is unnecessary, this patch adjusts the location of of_node_put() to avoid such scenario. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/soc')
-rw-r--r--drivers/soc/imx/soc-imx8.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index cd10726e64e4..d377a90f3a2f 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -115,8 +115,6 @@ static int __init imx8_soc_init(void)
if (!id)
goto free_soc;
- of_node_put(root);
-
data = id->data;
if (data) {
soc_dev_attr->soc_id = data->name;
@@ -132,6 +130,8 @@ static int __init imx8_soc_init(void)
if (IS_ERR(soc_dev))
goto free_rev;
+ of_node_put(root);
+
return 0;
free_rev: