summaryrefslogtreecommitdiff
path: root/drivers/staging/media/atomisp/include/linux/atomisp.h
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2023-03-05 20:57:45 +0300
committerMauro Carvalho Chehab <mchehab@kernel.org>2023-04-15 12:39:14 +0300
commitfa8730b06cb3e40c8fbc265202a10849146470b5 (patch)
tree7271b754f1ec72f1ba6c967abf509add7a9b93de /drivers/staging/media/atomisp/include/linux/atomisp.h
parentb3713bca92f6322bcd5ef1ef8137634db067fdc7 (diff)
downloadlinux-fa8730b06cb3e40c8fbc265202a10849146470b5.tar.xz
media: atomisp: Remove custom V4L2_CID_FMT_AUTO control
The custom V4L2_CID_FMT_AUTO control, which defaults to true controls whether the atomisp driver will automatically configure the sensor and ISP settings to match. This is necessary to make normal v4l2 apps to work. We do eventually want to add libcamera support, but even then moving this to userspace does not give any added value, while breaking classic v4l2 apps. Moreover we really don't know all the exact pipeline constraints, so moving this to userspace/libcamera will be tricky thus it is best to keep the current in kernel code for this and make the kernel unconditionally do this. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/staging/media/atomisp/include/linux/atomisp.h')
-rw-r--r--drivers/staging/media/atomisp/include/linux/atomisp.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/include/linux/atomisp.h b/drivers/staging/media/atomisp/include/linux/atomisp.h
index b3cceea570ca..c7ec56a1c064 100644
--- a/drivers/staging/media/atomisp/include/linux/atomisp.h
+++ b/drivers/staging/media/atomisp/include/linux/atomisp.h
@@ -1056,8 +1056,6 @@ struct atomisp_sensor_ae_bracketing_lut {
#define V4L2_2A_STATUS_AE_READY BIT(0)
#define V4L2_2A_STATUS_AWB_READY BIT(1)
-#define V4L2_CID_FMT_AUTO (V4L2_CID_CAMERA_LASTP1 + 19)
-
#define V4L2_CID_RUN_MODE (V4L2_CID_CAMERA_LASTP1 + 20)
#define ATOMISP_RUN_MODE_VIDEO 1
#define ATOMISP_RUN_MODE_STILL_CAPTURE 2