summaryrefslogtreecommitdiff
path: root/drivers/tty/nozomi.c
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-10-19 20:57:32 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-28 15:44:43 +0300
commit1a460c36078e1c7c979ce2ead581ec9e40f2aac8 (patch)
treec938056836a2ead32acc03431559c678a1f65051 /drivers/tty/nozomi.c
parent974e454d6f96da0c0ab1b4115b92587dd9406f6a (diff)
downloadlinux-1a460c36078e1c7c979ce2ead581ec9e40f2aac8.tar.xz
tty: nozomi: remove unneeded break
A break is not needed if it is preceded by a return Add explicit fallthrough Signed-off-by: Tom Rix <trix@redhat.com> Link: https://lore.kernel.org/r/20201019175732.3289-1-trix@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/nozomi.c')
-rw-r--r--drivers/tty/nozomi.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index d42b854cb7df..861e95043191 100644
--- a/drivers/tty/nozomi.c
+++ b/drivers/tty/nozomi.c
@@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start,
buf16 = (u16 *) buf;
*buf16 = __le16_to_cpu(readw(ptr));
goto out;
- break;
case 4: /* 4 bytes */
*(buf) = __le32_to_cpu(readl(ptr));
goto out;
- break;
}
while (i < size_bytes) {
@@ -460,15 +458,14 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,
buf16 = (const u16 *)buf;
writew(__cpu_to_le16(*buf16), ptr);
return 2;
- break;
case 1: /*
* also needs to write 4 bytes in this case
* so falling through..
*/
+ fallthrough;
case 4: /* 4 bytes */
writel(__cpu_to_le32(*buf), ptr);
return 4;
- break;
}
while (i < size_bytes) {