summaryrefslogtreecommitdiff
path: root/drivers/tty/rpmsg_tty.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-10-15 14:14:22 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-10-21 11:38:49 +0300
commit74365bc138ab03bdac205047aac02f8db0a479fa (patch)
tree6f47e5d493a5524a41b3ddadb6823491abf72bf2 /drivers/tty/rpmsg_tty.c
parentd2248ca8d6ba867fd9b2317af730ba73284d0989 (diff)
downloadlinux-74365bc138ab03bdac205047aac02f8db0a479fa.tar.xz
serial: 8250_dw: drop bogus uartclk optimisation
The driver was updating the port uartclk before setting the new rate in an attempt to avoid having the clock notifier redundantly update the divisors. The set_termios() callback is however called under the termios semaphore and tty-port mutex so the worker scheduled by the clock notifier will block in serial8250_update_uartclk() until the uartclk and divisors have been updated anyway. Drop the unnecessary swaps and incorrect comment and simply update the uartclk field if the clock-rate change was successful. Tested-by: Serge Semin <fancer.lancer@gmail.com> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20211015111422.1027-4-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/rpmsg_tty.c')
0 files changed, 0 insertions, 0 deletions