summaryrefslogtreecommitdiff
path: root/drivers/tty
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-01 13:49:23 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-11-04 14:08:53 +0300
commit9356335faf9f65568dbdb9bba2a07117f69d34c5 (patch)
treef43b164b3f95c38d51278a21df1f0b02a75c4bd1 /drivers/tty
parent1be2266392196de82d1cfcc8a68e770cf8f48c60 (diff)
downloadlinux-9356335faf9f65568dbdb9bba2a07117f69d34c5.tar.xz
serial: core: remove redundant assignment to port
The final assignment to port is never read, hence it is redundant and can be removed. Also move the declaration of port to a more local scope. Cleans up clang warning: drivers/tty/serial/serial_core.c:1498:2: warning: Value stored to 'port' is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/serial_core.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index f4e6c8662987..cdac01fe11ca 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1482,10 +1482,10 @@ out:
static void uart_close(struct tty_struct *tty, struct file *filp)
{
struct uart_state *state = tty->driver_data;
- struct tty_port *port;
if (!state) {
struct uart_driver *drv = tty->driver->driver_state;
+ struct tty_port *port;
state = drv->state + tty->index;
port = &state->port;
@@ -1495,7 +1495,6 @@ static void uart_close(struct tty_struct *tty, struct file *filp)
return;
}
- port = &state->port;
pr_debug("uart_close(%d) called\n", tty->index);
tty_port_close(tty->port, tty, filp);