diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-08 10:39:43 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-03-16 18:08:36 +0300 |
| commit | ea379bc80231c8a86730f854e436eff19a729950 (patch) | |
| tree | b9caff22285d13d3a166ff006072d65d1d329af0 /drivers/video/backlight/qcom-wled.c | |
| parent | 0a4606a7a4bc6f876354ff6d90b969172208eeef (diff) | |
| download | linux-ea379bc80231c8a86730f854e436eff19a729950.tar.xz | |
backlight: qcom-wled: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-12-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/video/backlight/qcom-wled.c')
| -rw-r--r-- | drivers/video/backlight/qcom-wled.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 5f504883aca5..c6996aa288e6 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1717,7 +1717,7 @@ static int wled_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(bl); }; -static int wled_remove(struct platform_device *pdev) +static void wled_remove(struct platform_device *pdev) { struct wled *wled = platform_get_drvdata(pdev); @@ -1725,8 +1725,6 @@ static int wled_remove(struct platform_device *pdev) cancel_delayed_work_sync(&wled->ovp_work); disable_irq(wled->short_irq); disable_irq(wled->ovp_irq); - - return 0; } static const struct of_device_id wled_match_table[] = { @@ -1743,7 +1741,7 @@ MODULE_DEVICE_TABLE(of, wled_match_table); static struct platform_driver wled_driver = { .probe = wled_probe, - .remove = wled_remove, + .remove_new = wled_remove, .driver = { .name = "qcom,wled", .of_match_table = wled_match_table, |