summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorHangyu Hua <hbh25y@gmail.com>2022-03-11 11:02:08 +0300
committerMarc Kleine-Budde <mkl@pengutronix.de>2022-03-31 10:55:27 +0300
commit04c9b00ba83594a29813d6b1fb8fdc93a3915174 (patch)
treec0a0c04bbd11c20e6b40870bcbeafd91a9b76493 /drivers
parent3d3925ff6433f98992685a9679613a2cc97f3ce2 (diff)
downloadlinux-04c9b00ba83594a29813d6b1fb8fdc93a3915174.tar.xz
can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
There is no need to call dev_kfree_skb() when usb_submit_urb() fails because can_put_echo_skb() deletes original skb and can_free_echo_skb() deletes the cloned skb. Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/can/usb/mcba_usb.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
index 77bddff86252..7c198eb5bc9c 100644
--- a/drivers/net/can/usb/mcba_usb.c
+++ b/drivers/net/can/usb/mcba_usb.c
@@ -364,7 +364,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb,
xmit_failed:
can_free_echo_skb(priv->netdev, ctx->ndx, NULL);
mcba_usb_free_ctx(ctx);
- dev_kfree_skb(skb);
stats->tx_dropped++;
return NETDEV_TX_OK;