summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2023-02-14 19:28:29 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2023-03-14 12:06:41 +0300
commit0e44db95eecb30aade0cac6cb8450e8bceeff4d2 (patch)
treecc19eae2a95af2a7afe0a93aff882f74412b0351 /drivers
parent67fb1e2958391ff005a049a147aa82920aef7921 (diff)
downloadlinux-0e44db95eecb30aade0cac6cb8450e8bceeff4d2.tar.xz
hwrng: xgene - Improve error reporting for problems during .remove()
Returning an error value in a platform driver's remove callback results in a generic error message being emitted by the driver core, but otherwise it doesn't make a difference. The device goes away anyhow. As the driver already emits a better error message than the core, suppress the generic error message by returning zero unconditionally. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/char/hw_random/xgene-rng.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index 31662614a48f..c67d3185b5b6 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -366,7 +366,7 @@ static int xgene_rng_remove(struct platform_device *pdev)
if (rc)
dev_err(&pdev->dev, "RNG init wakeup failed error %d\n", rc);
- return rc;
+ return 0;
}
static const struct of_device_id xgene_rng_of_match[] = {