summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorDavid HERNANDEZ SANCHEZ <david.hernandezsanchez@st.com>2018-12-06 16:23:32 +0300
committerEduardo Valentin <edubezval@gmail.com>2018-12-11 07:15:21 +0300
commit3c9d082064b5ec5876f7e20bc50959d1915c5ab0 (patch)
treed0c67dc0653a81429435cb722ab8785d90cf7961 /drivers
parent7d3a2a2bbadb4bf5856ed394ba09b8fbb7a80460 (diff)
downloadlinux-3c9d082064b5ec5876f7e20bc50959d1915c5ab0.tar.xz
thermal: stm32: read factory settings inside stm_thermal_prepare
Calling stm_thermal_read_factory_settings before clocking internal peripheral causes bad register values and makes temperature computation wrong. Calling stm_thermal_read_factory_settings inside stm_thermal_prepare fixes this problem as internal peripheral is well clocked at this stage. Fixes: 1d693155 ("thermal: add stm32 thermal driver") Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: David Hernandez Sanchez <david.hernandezsanchez@st.com> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/thermal/st/stm_thermal.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index 47623da0f91b..daa1257809a6 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -532,6 +532,10 @@ static int stm_thermal_prepare(struct stm_thermal_sensor *sensor)
if (ret)
return ret;
+ ret = stm_thermal_read_factory_settings(sensor);
+ if (ret)
+ goto thermal_unprepare;
+
ret = stm_thermal_calibration(sensor);
if (ret)
goto thermal_unprepare;
@@ -636,10 +640,6 @@ static int stm_thermal_probe(struct platform_device *pdev)
/* Populate sensor */
sensor->base = base;
- ret = stm_thermal_read_factory_settings(sensor);
- if (ret)
- return ret;
-
sensor->clk = devm_clk_get(&pdev->dev, "pclk");
if (IS_ERR(sensor->clk)) {
dev_err(&pdev->dev, "%s: failed to fetch PCLK clock\n",