diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2022-11-18 04:12:49 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-11-19 06:42:12 +0300 |
| commit | 7cef6b73fba96abef731a53501924fc3c4a0f947 (patch) | |
| tree | a34cd8c13e8f0f0955fe830a94fedb3c73064814 /drivers | |
| parent | 4d633d1b468b6eb107a81b2fd10b9debddca3d47 (diff) | |
| download | linux-7cef6b73fba96abef731a53501924fc3c4a0f947.tar.xz | |
macsec: Fix invalid error code set
'ret' is defined twice in macsec_changelink(), when it is set in macsec_is_offloaded
case, it will be invalid before return.
Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20221118011249.48112-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/macsec.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 85376d2f24ca..f41f67b583db 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -3835,7 +3835,6 @@ static int macsec_changelink(struct net_device *dev, struct nlattr *tb[], if (macsec_is_offloaded(macsec)) { const struct macsec_ops *ops; struct macsec_context ctx; - int ret; ops = macsec_get_ops(netdev_priv(dev), &ctx); if (!ops) { |