summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorCarlos Llamas <cmllamas@google.com>2022-05-10 02:19:01 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-05-19 19:41:11 +0300
commitda4864962d768b33e3bc31cd233270af6226686d (patch)
treed98d02206c083688c4fd7e9350020382b8efb006 /drivers
parentdc6a7effb48e7267c9f1314e3aa8cfe539bd6096 (diff)
downloadlinux-da4864962d768b33e3bc31cd233270af6226686d.tar.xz
binder: fix printk format for commands
Make sure we use unsigned format specifier %u for binder commands as most of them are encoded above INT_MAX. This prevents negative values when logging them as in the following case: [ 211.895781] binder: 8668:8668 BR_REPLY 258949 0:0, cmd -2143260157 size 0-0 ptr 0000006e766a8000-0000006e766a8000 Acked-by: Todd Kjos <tkjos@google.com> Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org> Signed-off-by: Carlos Llamas <cmllamas@google.com> Link: https://lore.kernel.org/r/20220509231901.3852573-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/android/binder.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index d9253b2a7bd9..176bb0463680 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -4083,7 +4083,7 @@ static int binder_thread_write(struct binder_proc *proc,
} break;
default:
- pr_err("%d:%d unknown command %d\n",
+ pr_err("%d:%d unknown command %u\n",
proc->pid, thread->pid, cmd);
return -EINVAL;
}
@@ -4578,7 +4578,7 @@ retry:
trace_binder_transaction_received(t);
binder_stat_br(proc, thread, cmd);
binder_debug(BINDER_DEBUG_TRANSACTION,
- "%d:%d %s %d %d:%d, cmd %d size %zd-%zd ptr %016llx-%016llx\n",
+ "%d:%d %s %d %d:%d, cmd %u size %zd-%zd ptr %016llx-%016llx\n",
proc->pid, thread->pid,
(cmd == BR_TRANSACTION) ? "BR_TRANSACTION" :
(cmd == BR_TRANSACTION_SEC_CTX) ?