summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2022-04-23 15:30:48 +0300
committerHans de Goede <hdegoede@redhat.com>2022-04-27 17:55:54 +0300
commiteb2fd9b43fae0c51982ac4229535b6cfd77380db (patch)
tree46db60bb4eb7ef8cc669309fc74a6f88d5e5cbb3 /drivers
parent00dd3ace931b4d2f6e5e9ccf4bf738fe46b64289 (diff)
downloadlinux-eb2fd9b43fae0c51982ac4229535b6cfd77380db.tar.xz
platform/x86/intel: pmc/core: change pmc_lpm_modes to static
Sparse reports this issue core.c: note: in included file: core.h:239:12: warning: symbol 'pmc_lpm_modes' was not declared. Should it be static? Global variables should not be defined in headers. This only works because core.h is only included by core.c. Single file use variables should be static, so change its storage-class specifier to static. Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: David E. Box <david.e.box@linux.intel.com> Link: https://lore.kernel.org/r/20220423123048.591405-1-trix@redhat.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/platform/x86/intel/pmc/core.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
index a46d3b53bf61..7a059e02c265 100644
--- a/drivers/platform/x86/intel/pmc/core.h
+++ b/drivers/platform/x86/intel/pmc/core.h
@@ -236,7 +236,7 @@ enum ppfear_regs {
#define ADL_LPM_STATUS_LATCH_EN_OFFSET 0x1704
#define ADL_LPM_LIVE_STATUS_OFFSET 0x1764
-const char *pmc_lpm_modes[] = {
+static const char *pmc_lpm_modes[] = {
"S0i2.0",
"S0i2.1",
"S0i2.2",