diff options
| author | David Howells <dhowells@redhat.com> | 2023-10-31 19:30:37 +0300 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2024-01-01 19:37:27 +0300 |
| commit | f49b594df3ebca53c91f4d6448680463f10aa479 (patch) | |
| tree | d18f0048178320274cf73b7e62c4cbb3a8ae9b80 /fs/afs/vl_alias.c | |
| parent | e6a7d7f71b17e0a44e2155bdad47eae7b5368503 (diff) | |
| download | linux-f49b594df3ebca53c91f4d6448680463f10aa479.tar.xz | |
afs: Keep a record of the current fileserver endpoint state
Keep a record of the current fileserver endpoint state, including the probe
state, and replace it when a new probe is started rather than just
squelching the old state and overwriting it. Clearance of the old state
can cause a race if there's another thread also currently trying to
communicate with that server.
It appears that this race might be the culprit for some occasions where
kafs complains about invalid data in the RPC reply because the rotation
algorithm fell all the way through without actually issuing an RPC call and
the error return got filled in from the probe state (which has a zero error
recorded). Whatever happens to be in the caller's reply buffer is then
taken as the response.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Diffstat (limited to 'fs/afs/vl_alias.c')
| -rw-r--r-- | fs/afs/vl_alias.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/afs/vl_alias.c b/fs/afs/vl_alias.c index 89cadd9a69e1..43788d0c18e8 100644 --- a/fs/afs/vl_alias.c +++ b/fs/afs/vl_alias.c @@ -41,8 +41,8 @@ static int afs_compare_fs_alists(const struct afs_server *server_a, const struct afs_addr_list *la, *lb; int a = 0, b = 0, addr_matches = 0; - la = rcu_dereference(server_a->addresses); - lb = rcu_dereference(server_b->addresses); + la = rcu_dereference(server_a->endpoint_state)->addresses; + lb = rcu_dereference(server_b->endpoint_state)->addresses; while (a < la->nr_addrs && b < lb->nr_addrs) { unsigned long pa = (unsigned long)la->addrs[a].peer; |