diff options
| author | David Howells <dhowells@redhat.com> | 2020-10-27 13:42:56 +0300 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-10-28 01:05:56 +0300 |
| commit | acc080d15dde820bd39eb55a04f9a09c7ef52e67 (patch) | |
| tree | d707ba3cf63ea76f91ce993571396f3c93d05d3b /fs/afs/xattr.c | |
| parent | 06a17bbe1d47fec6232505c355b367797f6a635c (diff) | |
| download | linux-acc080d15dde820bd39eb55a04f9a09c7ef52e67.tar.xz | |
afs: Fix tracing deref-before-check
The patch dca54a7bbb8c: "afs: Add tracing for cell refcount and active user
count" from Oct 13, 2020, leads to the following Smatch complaint:
fs/afs/cell.c:596 afs_unuse_cell()
warn: variable dereferenced before check 'cell' (see line 592)
Fix this by moving the retrieval of the cell debug ID to after the check of
the validity of the cell pointer.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: dca54a7bbb8c ("afs: Add tracing for cell refcount and active user count")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Dan Carpenter <dan.carpenter@oracle.com>
Diffstat (limited to 'fs/afs/xattr.c')
0 files changed, 0 insertions, 0 deletions