diff options
| author | Christoph Hellwig <hch@lst.de> | 2024-01-11 10:36:55 +0300 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-01-22 20:37:51 +0300 |
| commit | 3e44f325f6f75078cdcd44cd337f517ba3650d05 (patch) | |
| tree | d695962261fe0027d03e0eca07a33598c4bc5bd8 /fs/bcachefs/alloc_background.c | |
| parent | 612e1110d689387aab81b2727895cd307d3cbbfd (diff) | |
| download | linux-3e44f325f6f75078cdcd44cd337f517ba3650d05.tar.xz | |
bcachefs: fix incorrect usage of REQ_OP_FLUSH
REQ_OP_FLUSH is only for internal use in the blk-mq and request based
drivers. File systems and other block layer consumers must use
REQ_OP_WRITE | REQ_PREFLUSH as documented in
Documentation/block/writeback_cache_control.rst.
While REQ_OP_FLUSH appears to work for blk-mq drivers it does not
get the proper flush state machine handling, and completely fails
for any bio based drivers, including all the stacking drivers. The
block layer will also get a check in 6.8 to reject this use case
entirely.
[Note: completely untested, but as this never got fixed since the
original bug report in November:
https://bugzilla.kernel.org/show_bug.cgi?id=218184
and the the discussion in December:
https://lore.kernel.org/all/20231221053016.72cqcfg46vxwohcj@moria.home.lan/T/
this seems to be best way to force it]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/alloc_background.c')
0 files changed, 0 insertions, 0 deletions