diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2019-09-19 20:21:35 +0300 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-09-19 20:21:35 +0300 |
commit | 7a0d796100daa8e75cda2c166c85d57775704fd4 (patch) | |
tree | bd12f4de8cd61df8f4a74b38ba5c445db15beb09 /fs/f2fs/sysfs.c | |
parent | 8e6ee05d8aa9c802d999c79aa22f3f6ca92d7d27 (diff) | |
parent | e6b998ab62be29eb244fdb0fa41dcb5a8ad065f2 (diff) | |
download | linux-7a0d796100daa8e75cda2c166c85d57775704fd4.tar.xz |
Merge tag 'for-linus-5.4-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux
Pull orangefs updates from Mike Marshall:
"A fix and a cleanup.
The fix: way back in the stone age (2003) mode was set to the magic
number "755" in what is now fs/orangefs/namei.c(orangefs_symlink).
Łukasz Wrochna reported it and Artur Świgoń sent in a patch to change
it to octal. Maybe it shouldn't be a magic number at all but rather
something like "S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH"...
cleanup: Colin Ian King found a redundant assignment and sent in a
patch to remove it"
[ And no, octal numbers for permissions are a lot more legible than a
binary 'or' of some line noise macros. So 0755 is preferred over
trying to spell it out using "helpful" macros - Linus ]
* tag 'for-linus-5.4-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux:
orangefs: remove redundant assignment to err
orangefs: Add octal zero prefix
Diffstat (limited to 'fs/f2fs/sysfs.c')
0 files changed, 0 insertions, 0 deletions