diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2024-02-13 03:11:47 +0300 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2024-02-23 11:40:26 +0300 |
| commit | 40488cc16f7ea0d193a4e248f0d809c25cc377db (patch) | |
| tree | 3077ad4b31704f68ee056578ed5d2ffbdf4f3a08 /fs/fuse | |
| parent | b401b621758e46812da61fa58a67c3fd8d91de0d (diff) | |
| download | linux-40488cc16f7ea0d193a4e248f0d809c25cc377db.tar.xz | |
virtiofs: forbid newlines in tags
Newlines in virtiofs tags are awkward for users and potential vectors
for string injection attacks.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse')
| -rw-r--r-- | fs/fuse/virtio_fs.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 5f1be1da92ce..d84dacbdce2c 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -323,6 +323,16 @@ static int virtio_fs_read_tag(struct virtio_device *vdev, struct virtio_fs *fs) return -ENOMEM; memcpy(fs->tag, tag_buf, len); fs->tag[len] = '\0'; + + /* While the VIRTIO specification allows any character, newlines are + * awkward on mount(8) command-lines and cause problems in the sysfs + * "tag" attr and uevent TAG= properties. Forbid them. + */ + if (strchr(fs->tag, '\n')) { + dev_dbg(&vdev->dev, "refusing virtiofs tag with newline character\n"); + return -EINVAL; + } + return 0; } |