summaryrefslogtreecommitdiff
path: root/fs/isofs
diff options
context:
space:
mode:
authorZhang Yi <yi.zhang@huawei.com>2022-09-01 16:34:56 +0300
committerAndrew Morton <akpm@linux-foundation.org>2022-09-12 06:26:06 +0300
commit0ed48061887f603b33b7dcb9075cbfaaa8d02723 (patch)
tree662a4ecb23594acaa38e111e9df8435f821fa0ff /fs/isofs
parent86a020cc7232c3defad370852415876bbe4576dc (diff)
downloadlinux-0ed48061887f603b33b7dcb9075cbfaaa8d02723.tar.xz
isofs: replace ll_rw_block()
ll_rw_block() is not safe for the sync read path because it cannot guarantee that submitting read IO if the buffer has been locked. We could get false positive EIO return from zisofs_uncompress_block() if he buffer has been locked by others. So stop using ll_rw_block(), switch to sync helper instead. Link: https://lkml.kernel.org/r/20220901133505.2510834-6-yi.zhang@huawei.com Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'fs/isofs')
-rw-r--r--fs/isofs/compress.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
index b466172eec25..59b03d74ecbe 100644
--- a/fs/isofs/compress.c
+++ b/fs/isofs/compress.c
@@ -82,7 +82,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
return 0;
}
haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks);
- ll_rw_block(REQ_OP_READ, haveblocks, bhs);
+ bh_read_batch(haveblocks, bhs);
curbh = 0;
curpage = 0;