diff options
| author | Aleksa Sarai <cyphar@cyphar.com> | 2023-07-13 17:09:58 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-07-13 17:30:52 +0300 |
| commit | ccf61486fe1e1a48e18c638d1813cda77b3c0737 (patch) | |
| tree | cbdca963e2a40b262ba8a035864172b3e054e0b5 /fs/proc/proc_tty.c | |
| parent | 18e66ae67673f2c8df6f02428798b1355691f2a9 (diff) | |
| download | linux-ccf61486fe1e1a48e18c638d1813cda77b3c0737.tar.xz | |
procfs: block chmod on /proc/thread-self/comm
Due to an oversight in commit 1b3044e39a89 ("procfs: fix pthread
cross-thread naming if !PR_DUMPABLE") in switching from REG to NOD,
chmod operations on /proc/thread-self/comm were no longer blocked as
they are on almost all other procfs files.
A very similar situation with /proc/self/environ was used to as a root
exploit a long time ago, but procfs has SB_I_NOEXEC so this is simply a
correctness issue.
Ref: https://lwn.net/Articles/191954/
Ref: 6d76fa58b050 ("Don't allow chmod() on the /proc/<pid>/ files")
Fixes: 1b3044e39a89 ("procfs: fix pthread cross-thread naming if !PR_DUMPABLE")
Cc: stable@vger.kernel.org # v4.7+
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Message-Id: <20230713141001.27046-1-cyphar@cyphar.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/proc/proc_tty.c')
0 files changed, 0 insertions, 0 deletions