summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@redhat.com>2016-10-04 15:40:44 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2016-10-14 12:16:46 +0300
commitcb348edb6bef7250d1d0f8f2d7dac152d8b52626 (patch)
tree166b20d741c93b36a960fbf9092920ffcee45273 /fs
parent6a45b3628ce4dcf7498b39c87d475bab6e2a9b24 (diff)
downloadlinux-cb348edb6bef7250d1d0f8f2d7dac152d8b52626.tar.xz
ovl: explain error values when removing acl from workdir
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/overlayfs/super.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 8ccebaf64c5b..eff0f909cd78 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -832,6 +832,19 @@ retry:
if (err)
goto out_dput;
+ /*
+ * Try to remove POSIX ACL xattrs from workdir. We are good if:
+ *
+ * a) success (there was a POSIX ACL xattr and was removed)
+ * b) -ENODATA (there was no POSIX ACL xattr)
+ * c) -EOPNOTSUPP (POSIX ACL xattrs are not supported)
+ *
+ * There are various other error values that could effectively
+ * mean that the xattr doesn't exist (e.g. -ERANGE is returned
+ * if the xattr name is too long), but the set of filesystems
+ * allowed as upper are limited to "normal" ones, where checking
+ * for the above two errors is sufficient.
+ */
err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_DEFAULT);
if (err && err != -ENODATA && err != -EOPNOTSUPP)
goto out_dput;