diff options
| author | Kees Cook <keescook@chromium.org> | 2023-08-18 02:59:56 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-08-26 02:07:30 +0300 |
| commit | 5f536ac6a5a7b67351e4e5ae4f9e1e57d31268e6 (patch) | |
| tree | ed211e9dde27ef90f078f58cbd6d717dc2a5d0b9 /include/linux/dm-verity-loadpin.h | |
| parent | 76903a9648744c081547c91f31ec3917204b74e5 (diff) | |
| download | linux-5f536ac6a5a7b67351e4e5ae4f9e1e57d31268e6.tar.xz | |
LoadPin: Annotate struct dm_verity_loadpin_trusted_root_digest with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct dm_verity_loadpin_trusted_root_digest.
Additionally, since the element count member must be set before accessing
the annotated flexible array member, move its initialization earlier.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: dm-devel@redhat.com
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-security-module@vger.kernel.org
Link: https://lore.kernel.org/r/20230817235955.never.762-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'include/linux/dm-verity-loadpin.h')
| -rw-r--r-- | include/linux/dm-verity-loadpin.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/dm-verity-loadpin.h b/include/linux/dm-verity-loadpin.h index 552b817ab102..3ac6dbaeaa37 100644 --- a/include/linux/dm-verity-loadpin.h +++ b/include/linux/dm-verity-loadpin.h @@ -12,7 +12,7 @@ extern struct list_head dm_verity_loadpin_trusted_root_digests; struct dm_verity_loadpin_trusted_root_digest { struct list_head node; unsigned int len; - u8 data[]; + u8 data[] __counted_by(len); }; #if IS_ENABLED(CONFIG_SECURITY_LOADPIN_VERITY) |