diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-13 23:51:55 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-15 13:49:55 +0300 |
| commit | 289d3b21fb0bfc94c4e98f10635bba1824e5f83c (patch) | |
| tree | 5e796fd71b5154ce25a4434c3cc05f2dbe0c82e0 /include/net/inet_sock.h | |
| parent | 7bf9e18d9a5e99e3c83482973557e9f047b051e7 (diff) | |
| download | linux-289d3b21fb0bfc94c4e98f10635bba1824e5f83c.tar.xz | |
ip: Fix data-races around sysctl_ip_nonlocal_bind.
While reading sysctl_ip_nonlocal_bind, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/inet_sock.h')
| -rw-r--r-- | include/net/inet_sock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index daead5fb389a..68d337775564 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -374,7 +374,7 @@ static inline bool inet_get_convert_csum(struct sock *sk) static inline bool inet_can_nonlocal_bind(struct net *net, struct inet_sock *inet) { - return net->ipv4.sysctl_ip_nonlocal_bind || + return READ_ONCE(net->ipv4.sysctl_ip_nonlocal_bind) || inet->freebind || inet->transparent; } |