summaryrefslogtreecommitdiff
path: root/include/net/llc_conn.h
diff options
context:
space:
mode:
authorCong Wang <xiyou.wangcong@gmail.com>2018-03-27 01:08:33 +0300
committerDavid S. Miller <davem@davemloft.net>2018-03-27 18:56:00 +0300
commitb85ab56c3f81c5a24b5a5213374f549df06430da (patch)
tree4580d5ab329020259c744ca5b5accae6997258c9 /include/net/llc_conn.h
parent2a7fdec98f74cc305c1247cbe67307d504a3223d (diff)
downloadlinux-b85ab56c3f81c5a24b5a5213374f549df06430da.tar.xz
llc: properly handle dev_queue_xmit() return value
llc_conn_send_pdu() pushes the skb into write queue and calls llc_conn_send_pdus() to flush them out. However, the status of dev_queue_xmit() is not returned to caller, in this case, llc_conn_state_process(). llc_conn_state_process() needs hold the skb no matter success or failure, because it still uses it after that, therefore we should hold skb before dev_queue_xmit() when that skb is the one being processed by llc_conn_state_process(). For other callers, they can just pass NULL and ignore the return value as they are. Reported-by: Noam Rathaus <noamr@beyondsecurity.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/llc_conn.h')
-rw-r--r--include/net/llc_conn.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/llc_conn.h b/include/net/llc_conn.h
index fe994d2e5286..5c40f118c0fa 100644
--- a/include/net/llc_conn.h
+++ b/include/net/llc_conn.h
@@ -103,7 +103,7 @@ void llc_sk_reset(struct sock *sk);
/* Access to a connection */
int llc_conn_state_process(struct sock *sk, struct sk_buff *skb);
-void llc_conn_send_pdu(struct sock *sk, struct sk_buff *skb);
+int llc_conn_send_pdu(struct sock *sk, struct sk_buff *skb);
void llc_conn_rtn_pdu(struct sock *sk, struct sk_buff *skb);
void llc_conn_resend_i_pdu_as_cmd(struct sock *sk, u8 nr, u8 first_p_bit);
void llc_conn_resend_i_pdu_as_rsp(struct sock *sk, u8 nr, u8 first_f_bit);