diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-05-14 17:24:48 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-05-17 23:51:35 +0300 |
commit | 31db0dbd72444abe645d90c20ecb84d668f5af5e (patch) | |
tree | e5775d99dc39b62639cde7b551e80e090aaa5f11 /include/net/nfc/nci_core.h | |
parent | b7df21cf1b79ab7026f545e7bf837bd5750ac026 (diff) | |
download | linux-31db0dbd72444abe645d90c20ecb84d668f5af5e.tar.xz |
net: hso: check for allocation failure in hso_create_bulk_serial_device()
In current kernels, small allocations never actually fail so this
patch shouldn't affect runtime.
Originally this error handling code written with the idea that if
the "serial->tiocmget" allocation failed, then we would continue
operating instead of bailing out early. But in later years we added
an unchecked dereference on the next line.
serial->tiocmget->serial_state_notification = kzalloc();
^^^^^^^^^^^^^^^^^^
Since these allocations are never going fail in real life, this is
mostly a philosophical debate, but I think bailing out early is the
correct behavior that the user would want. And generally it's safer to
bail as soon an error happens.
Fixes: af0de1303c4e ("usb: hso: obey DMA rules in tiocmget")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/nfc/nci_core.h')
0 files changed, 0 insertions, 0 deletions