summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorVivek Trivedi <vtrivedi018@gmail.com>2012-03-15 22:28:52 +0400
committerTrond Myklebust <Trond.Myklebust@netapp.com>2012-03-21 19:45:28 +0400
commit5a7c9eec9fde1da0e3adf0a4ddb64ff2a324a492 (patch)
treef6ca94e7356996f9e29d6baa0fea67d3a499f9f0 /include
parent9b78145c0f280d4f01c460d6251eab2584181fa9 (diff)
downloadlinux-5a7c9eec9fde1da0e3adf0a4ddb64ff2a324a492.tar.xz
NFS: fix sb->s_id in nfs debug prints
NFS bdi flush thread in ps output is printed like "flush-<major number in decimal>:<minor number in decimal>" For example: $ ps aux | grep flush 2079 root 0 SW [flush-0:18] ^^^^ nfs_bdi_register() ==> bdi_register_dev() ==> bdi_register(bdi, NULL, "%u:%u", MAJOR(dev), MINOR(dev)); ^^^^^ However, NFS sb->s_id store major:minor number in hex: nfs_initialise_sb() ==> snprintf(sb->s_id, sizeof(sb->s_id), "%x:%x", MAJOR(sb->s_dev), MINOR(sb->s_dev)); ^^^^^ If we enable nfs debug prints using command: $ rpcdebug -m nfs -s all write to a file: $ dd if=/dev/zero of=<NFS Mount>/testfile.txt bs=32768 count=1 Without Patch: [ 2431.032000] NFS: 0 initiated write call (req 0:12/40, 32768 bytes @ offset 0) ^^^^ With Patch: [ 2431.032000] NFS: 0 initiated write call (req 0:18/40, 32768 bytes @ offset 0) ^^^^ We should store NFS "s->s_id" in decimal to avoid confusion between NFS flush thread name(in ps output) and NFS debug prints. Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions